Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classification events #6226

Merged
merged 8 commits into from
Feb 17, 2022
Merged

Classification events #6226

merged 8 commits into from
Feb 17, 2022

Conversation

mandy-chessell
Copy link
Contributor

@mandy-chessell mandy-chessell commented Feb 16, 2022 •
edited
Loading

Description

This pull request re-establishes OMRS classification events when the classification is on an event proxy. The event proxy is sent in the event notification. This had a knock on effect in 3 OMASs Topic listeners that assumes there would also always be an entity with the classification events.

  • For Asset Catalog OMAS and Asset Lineage OMAS I have added a test for null against the entity - this avoids the NPE but means that many classificaiton events will be ignored. @lpalashevski
  • For Asset Consumer OMES, it is retrieving the entity and processing the event as before.

Fixes # (issue)

How Has This Been Tested?

FVT and also through the dojo code

Any additional notes for reviewers?

@mandy-chessell mandy-chessell merged commit 8d057c1 into odpi:master Feb 17, 2022
@mandy-chessell mandy-chessell changed the title Egeria code Classification events Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcpopa lcpopa Awaiting requested review from lcpopa

@popa-raluca popa-raluca Awaiting requested review from popa-raluca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mandy-chessell